Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix memory overhead of getScopedCopy() #834

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

s2b
Copy link
Contributor

@s2b s2b commented Nov 23, 2023

The previous implementation of getScopedCopy() in the new ScopedVariableProvider copied both local and global variables. This is not necessary because all variables (except for settings) are provided explicitly and thus existing data in the data structure is irrelevant.

The new implementation reduces that unnecessary overhead by returning a StandardVariableProvider instead.

The previous implementation of getScopedCopy() in the new
ScopedVariableProvider copied both local and global variables.
This is not necessary because all variables (except for settings)
are provided explicitly and thus existing data in the data
structure is irrelevant.

The new implementation reduces that unnecessary overhead
by returning a StandardVariableProvider instead.
@s2b s2b merged commit 0f9a0a8 into main Nov 23, 2023
6 checks passed
@s2b s2b deleted the bugfix/scopedCopy branch November 23, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants