[TASK] Drop all @noinspection comments

TYPO3GmbH · May 10, 2023 · f8737ee · f8737ee
1 parent 3c87b53
commit f8737ee
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 19 deletions.
diff --git a/Classes/Controller/PostController.php b/Classes/Controller/PostController.php
@@ -269,7 +269,6 @@ public function listPostsByCategoryAction(Category $category = null, int $curren
             );
 
             if (!empty($categories)) {
-                /** @noinspection CallableParameterUseCaseInTypeContextInspection */
                 $category = $categories->getFirst();
             }
         }

diff --git a/Classes/Domain/Repository/CommentRepository.php b/Classes/Domain/Repository/CommentRepository.php
@@ -180,7 +180,6 @@ public function fillConstraintsBySettings(QueryInterface $query, array $constrai
             ? (int)$this->settings['comments']['respectPostLanguageId']
             : 0;
         if ($respectPostLanguageId) {
-            /** @noinspection PhpUnhandledExceptionInspection */
             $constraints[] = $query->logicalOr([
                 $query->equals('postLanguageId', GeneralUtility::makeInstance(Context::class)->getAspect('language')->getId()),
                 $query->equals('postLanguageId', -1),

diff --git a/Classes/Domain/Repository/TagRepository.php b/Classes/Domain/Repository/TagRepository.php
@@ -90,7 +90,6 @@ public function findTopByUsage($limit = 20)
         }
 
         // Shuffle tags, ordering is only to get the top used tags
-        /** @noinspection NonSecureShuffleUsageInspection */
         shuffle($rows);
         return $rows;
     }

diff --git a/Classes/Service/CommentService.php b/Classes/Service/CommentService.php
@@ -114,7 +114,6 @@ public function addComment(Post $post, Comment $comment): string
                 default:
             }
             $comment->setPid($post->getUid());
-            /** @noinspection PhpUnhandledExceptionInspection */
             $comment->setPostLanguageId(GeneralUtility::makeInstance(Context::class)->getAspect('language')->getId());
             $post->addComment($comment);
             $this->postRepository->update($post);

diff --git a/Classes/Service/SetupService.php b/Classes/Service/SetupService.php
@@ -70,7 +70,6 @@ public function createBlogSetup(array $data): bool
 
         $result = false;
         if (file_exists($blogSetup)) {
-            // @noinspection PhpIncludeInspection
             $blogSetup = require $blogSetup;
             if ($title !== null) {
                 $blogSetup['pages']['NEW_blogRoot']['title'] = $title;
@@ -99,7 +98,6 @@ public function createBlogSetup(array $data): bool
 
                 $blogSetupRelations = GeneralUtility::getFileAbsFileName('EXT:blog/Configuration/DataHandler/BlogSetupRelations.php');
                 if (file_exists($blogSetupRelations)) {
-                    // @noinspection PhpIncludeInspection
                     $blogSetupRelations = require $blogSetupRelations;
                     $blogSetupRelations = $this->replaceNewUids($blogSetupRelations);
                     $dataHandler = GeneralUtility::makeInstance(DataHandler::class);

diff --git a/Configuration/TCA/Overrides/pages.php b/Configuration/TCA/Overrides/pages.php
@@ -216,7 +216,6 @@
     ]
 );
 
-/** @noinspection UnsupportedStringOffsetOperationsInspection */
 $GLOBALS['TCA']['pages']['types'][\T3G\AgencyPack\Blog\Constants::DOKTYPE_BLOG_POST]['columnsOverrides'] = [
     'categories' => [
         'config' => [

diff --git a/ext_localconf.php b/ext_localconf.php
@@ -217,45 +217,33 @@ function () {
             ]
         );
 
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['processDatamapClass']['Blog'] =
             \T3G\AgencyPack\Blog\Hooks\DataHandlerHook::class;
 
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update']['T3G\AgencyPack\Blog\Install\Updates\DatabaseMonthYearUpdate']
             = \T3G\AgencyPack\Blog\Updates\DatabaseMonthYearUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update']['T3G\AgencyPack\Blog\Install\Updates\DatabasePublishDateUpdate']
             = \T3G\AgencyPack\Blog\Updates\DatabasePublishDateUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update']['T3G\AgencyPack\Blog\Install\Updates\AvatarProviderUpdate']
             = \T3G\AgencyPack\Blog\Updates\AvatarProviderUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\T3G\AgencyPack\Blog\Updates\CategorySlugUpdate::class]
             = \T3G\AgencyPack\Blog\Updates\CategorySlugUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\T3G\AgencyPack\Blog\Updates\CategoryTypeUpdate::class]
             = \T3G\AgencyPack\Blog\Updates\CategoryTypeUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\T3G\AgencyPack\Blog\Updates\AuthorSlugUpdate::class]
             = \T3G\AgencyPack\Blog\Updates\AuthorSlugUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\T3G\AgencyPack\Blog\Updates\TagSlugUpdate::class]
             = \T3G\AgencyPack\Blog\Updates\TagSlugUpdate::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\T3G\AgencyPack\Blog\Updates\FeaturedImageUpdate::class]
             = \T3G\AgencyPack\Blog\Updates\FeaturedImageUpdate::class;
 
         // Register Static Database Mapper
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['routing']['aspects']['BlogStaticDatabaseMapper'] =
             \T3G\AgencyPack\Blog\Routing\Aspect\StaticDatabaseMapper::class;
 
         // Register Notification visitors
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['Blog']['notificationRegistry'][\T3G\AgencyPack\Blog\Notification\CommentAddedNotification::class][]
             = \T3G\AgencyPack\Blog\Notification\Processor\AdminNotificationProcessor::class;
-        /** @noinspection UnsupportedStringOffsetOperationsInspection */
         $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['Blog']['notificationRegistry'][\T3G\AgencyPack\Blog\Notification\CommentAddedNotification::class][]
             = \T3G\AgencyPack\Blog\Notification\Processor\AuthorNotificationProcessor::class;
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 );
                 if (!empty($categories)) {
-                    /** @noinspection CallableParameterUseCaseInTypeContextInspection */
                     $category = $categories->getFirst();
                 }
             }
@@ Expand Down @@