Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][FEATURE] Modernize metadata rendering #84

Merged
merged 8 commits into from
Jun 28, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TASK] Deprecate meta action
  • Loading branch information
benjaminkott committed Jun 25, 2019
commit a4353b2f421781d3bc17c71ff423908d6c64963a
7 changes: 7 additions & 0 deletions Classes/Controller/PostController.php
Original file line number Diff line number Diff line change
@@ -312,9 +312,16 @@ public function footerAction(): void
* @throws \TYPO3\CMS\Core\Context\Exception\AspectNotFoundException
* @throws \TYPO3\CMS\Extbase\Configuration\Exception\InvalidConfigurationTypeException
* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
*
* @deprecated
*/
public function metadataAction(): void
{
trigger_error(
'Using \T3G\AgencyPack\Blog\Controller\PostController::metadataAction is deprecated. Use headerAction or footerAction instead.',
E_USER_DEPRECATED
);

$post = $this->postRepository->findCurrentPost();
$this->view->assign('post', $post);
if ($post instanceof Post) {
9 changes: 0 additions & 9 deletions Configuration/TsConfig/Page/Wizards.tsconfig
Original file line number Diff line number Diff line change
@@ -77,15 +77,6 @@ mod.wizards.newContentElement.wizardItems.blog {
list_type = blog_footer
}
}
blog_metadata {
iconIdentifier = plugin-blog-metadata
title = LLL:EXT:blog/Resources/Private/Language/locallang_db.xlf:plugin.blog_metadata.title
description = LLL:EXT:blog/Resources/Private/Language/locallang_db.xlf:plugin.blog_metadata.description
tt_content_defValues {
CType = list
list_type = blog_metadata
}
}
blog_commentform {
iconIdentifier = plugin-blog-commentform
title = LLL:EXT:blog/Resources/Private/Language/locallang_db.xlf:plugin.blog_commentform.title
3 changes: 2 additions & 1 deletion Configuration/TypoScript/Static/setup.typoscript
Original file line number Diff line number Diff line change
@@ -129,7 +129,8 @@ plugin.tx_blog {
}
}
}
default =< .listheader
# @Deprecated will be removed with v11
data < .listheader
}

# Lists related settings
2 changes: 1 addition & 1 deletion Resources/Private/Language/locallang_db.xlf
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@
<source>Displays post footer</source>
</trans-unit>
<trans-unit id="plugin.blog_metadata.title" xml:space="preserve">
<source>Blog: Metadata</source>
<source>Blog: Metadata (Deprecated, will be removed with v11)</source>
</trans-unit>
<trans-unit id="plugin.blog_metadata.description" xml:space="preserve">
<source>Displays post meta data, like date, tags, category, sharing links...</source>
2 changes: 2 additions & 0 deletions Resources/Private/Partials/Meta/Data.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<f:variable name="metatype" value="data" />
<f:render partial="Meta/Rendering/Section" arguments="{_all}" />
2 changes: 1 addition & 1 deletion Resources/Private/Templates/Post/Metadata.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<f:render partial="Meta/List" arguments="{_all}" />
<f:render partial="Meta/Data" arguments="{_all}" />