feat(vscode): add proxy support for vscode #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eryue0220
commented
Aug 20, 2024
eryue0220
commented
- This pr is to solve Support http proxy config in VSCode settings #2893
wsxiaoys
reviewed
Aug 20, 2024
| proxy?: { | ||
| authorization: string; | ||
| url: string; | ||
| noProxy: string | string[]; |
There was a problem hiding this comment.
Suggested change
| noProxy: string | string[]; |
I recommend removing this option for convenient of implementation in first step
wsxiaoys
reviewed
Aug 25, 2024
| @@ -12,6 +12,7 @@ export type AgentConfig = { | |||
| requestTimeout: number; | |||
| }; | |||
| proxy: { | |||
| proxySupport: "on" | "off"; | |||
There was a problem hiding this comment.
Suggested change
| proxySupport: "on" | "off"; | |
| enabled: boolean |
No need to reuse the variable name from vscode workspace, as AgentConfig is IDE / Extension agnostic.
|
Please also rebase against main branch |
wsxiaoys
reviewed
Aug 27, 2024
| const fieldsToCheck = [ | ||
| { | ||
| key: "server.endpoint", | ||
| validation: (key: string, x: string) => { |
There was a problem hiding this comment.
Suggested change
| validation: (key: string, x: string) => { | |
| validation: (key: keyof ClientProvidedConfig, x: string) => { |
Just use explict type?
wsxiaoys
reviewed
Aug 27, 2024
| }, | ||
| { | ||
| key: "server.token", | ||
| validation: (key: string, x: string) => { |
There was a problem hiding this comment.
ditto, and the function can be reused?
There was a problem hiding this comment.
Right, I just struggled with type and ignored.
icycodes
reviewed
Aug 28, 2024
| @@ -12,6 +12,8 @@ export type AgentConfig = { | |||
| requestTimeout: number; | |||
| }; | |||
| proxy: { | |||
| enabled: boolean; | |||
There was a problem hiding this comment.
I prefer to not add proxy.enabled. You can set the proxy.url to empty to disable the proxy.
wsxiaoys
approved these changes
Aug 28, 2024
icycodes
requested changes
Aug 29, 2024
icycodes
approved these changes
Aug 30, 2024
icycodes
pushed a commit
that referenced
this pull request
Sep 2, 2024
* feat: add proxy support for vscode * feat: complete proxy feature * feat: add proxy support for vscode * fix: remove noProxy configuration * fix: update configuration strategy * fix: support vscode proxy update * [autofix.ci] apply automated fixes * fix: cr * feat: reactor init function * [autofix.ci] apply automated fixes * feat: refactor configuration init & update * fix: format * fix: cr * fix: cr * fix: cr bug --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.