-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Support open chat in editor / open chat in new window … #3135
Merged
icycodes
merged 30 commits into
TabbyML:main
from
antimonyGu:open-tabby-chat-new-window-rebase
Sep 24, 2024
Merged
feat(vscode): Support open chat in editor / open chat in new window … #3135
icycodes
merged 30 commits into
TabbyML:main
from
antimonyGu:open-tabby-chat-new-window-rebase
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49a8bb0
to
09bc47a
Compare
09bc47a
to
500768c
Compare
|
d4c6a29
to
7786c6d
Compare
@icycodes Can you please review this PR when you are free? Thanks! |
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
approved these changes
Sep 19, 2024
wsxiaoys
added a commit
that referenced
this pull request
Sep 24, 2024
…#3135) * feat(chat-ui): Support open chat in editor / open chat in new window for Tabby Chat * Update ChatPanelViewProvider * instantiate WebviewHelper in ViewProvidor * migrate checkChatPanel * migrate displayChatPage * fix displayChatPage * migrate getFocusKeybinding * migrate displayDisconnectedPage * fix displayDisconnectedPage * add setClient in webviewHelper * migrate sendMessageToChatPanel * migrate addRelevantContext to WebviewHelper * migrate refreshChatPage to WebviewHelper * migrate formatLineHashForCodeBrowser to WebviewHelper * migrate sendMessage to WebviewHelper * abstract addAgentEventListeners in WebviewHelper * abstract displayPageBasedOnServerStatus in WebviewHelper * refactor createClient * delete getFileContextFromEditor in ChatPanelViewProvider * migrate r esolveFilePathAndGitUrl to WebviewHelper * migrate getFileContextFromSelection to ChatSideViewProvider * migrate resolveWebviewView to WebviewHelper * create createChatClient in WebviewHelper * clean up import * migrate getColorThemeString to WebviewHelper * fix lint * fix lint * Update clients/vscode/package.json * Update clients/vscode/src/Commands.ts --------- Co-authored-by: Meng Zhang <meng@tabbyml.com> Co-authored-by: Zhiming Ma <codes.icy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2944
Manually test create chat panel then send a hello world message.
https://jam.dev/c/606f0750-4c5c-44e5-9c4a-8c2ce06ddf2f cc @icycodes