Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Support open chat in editor / open chat in new window … #3135

Merged
merged 30 commits into from
Sep 24, 2024

Conversation

antimonyGu
Copy link
Contributor

@antimonyGu antimonyGu commented Sep 12, 2024

close #2944

  • Test:

Manually test create chat panel then send a hello world message.

@antimonyGu antimonyGu marked this pull request as draft September 12, 2024 18:55
@antimonyGu antimonyGu force-pushed the open-tabby-chat-new-window-rebase branch from 49a8bb0 to 09bc47a Compare September 13, 2024 21:44
@antimonyGu antimonyGu force-pushed the open-tabby-chat-new-window-rebase branch from 09bc47a to 500768c Compare September 14, 2024 04:44
@antimonyGu antimonyGu marked this pull request as ready for review September 14, 2024 04:53
@antimonyGu
Copy link
Contributor Author

getFileContextFromSelection createClient getFileContextFromEditor to be refactored into helper cause they couple with each other. @wsxiaoys

@antimonyGu antimonyGu force-pushed the open-tabby-chat-new-window-rebase branch from d4c6a29 to 7786c6d Compare September 16, 2024 06:15
@antimonyGu
Copy link
Contributor Author

rebase version of PR(#3131). cc @wsxiaoys

@wsxiaoys wsxiaoys requested a review from icycodes September 16, 2024 12:26
@antimonyGu
Copy link
Contributor Author

@icycodes Can you please review this PR when you are free? Thanks!

@antimonyGu
Copy link
Contributor Author

@icycodes BTW, Can you please re-trigger the CI jobs. Thansk! cc @wsxiaoys

@icycodes icycodes changed the title feat(chat-ui): Support open chat in editor / open chat in new window … feat(vscode): Support open chat in editor / open chat in new window … Sep 20, 2024
@icycodes icycodes merged commit 49bf6dc into TabbyML:main Sep 24, 2024
3 checks passed
wsxiaoys added a commit that referenced this pull request Sep 24, 2024
…#3135)

* feat(chat-ui): Support open chat in editor / open chat in new window for Tabby Chat

* Update ChatPanelViewProvider

* instantiate WebviewHelper in ViewProvidor

* migrate checkChatPanel

* migrate displayChatPage

* fix displayChatPage

* migrate getFocusKeybinding

* migrate displayDisconnectedPage

* fix displayDisconnectedPage

* add setClient in webviewHelper

* migrate sendMessageToChatPanel

* migrate addRelevantContext to WebviewHelper

* migrate refreshChatPage to WebviewHelper

* migrate formatLineHashForCodeBrowser to WebviewHelper

* migrate sendMessage to WebviewHelper

* abstract addAgentEventListeners in WebviewHelper

* abstract displayPageBasedOnServerStatus in WebviewHelper

* refactor createClient

* delete getFileContextFromEditor in ChatPanelViewProvider

* migrate r esolveFilePathAndGitUrl to WebviewHelper

* migrate getFileContextFromSelection to ChatSideViewProvider

* migrate resolveWebviewView to WebviewHelper

* create  createChatClient in WebviewHelper

* clean up import

* migrate getColorThemeString to WebviewHelper

* fix lint

* fix lint

* Update clients/vscode/package.json

* Update clients/vscode/src/Commands.ts

---------

Co-authored-by: Meng Zhang <meng@tabbyml.com>
Co-authored-by: Zhiming Ma <codes.icy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support open chat in editor / open chat in new window for Tabby Chat
3 participants