Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Ruby Language Support #597

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: Add Ruby Language Support #597

merged 3 commits into from
Oct 20, 2023

Conversation

CrCs2O4
Copy link
Contributor

@CrCs2O4 CrCs2O4 commented Oct 19, 2023

Thanks a lot for a great project! Happy to contribute support of the Ruby programming language (based on Support for golang)

  • Stop words support
  • Repository context support
  • Update documentation / changelog

also

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Adding a few comments

crates/tabby-common/assets/languages.toml Show resolved Hide resolved
crates/tabby-scheduler/queries/ruby.scm Outdated Show resolved Hide resolved
website/docs/programming-languages.md Outdated Show resolved Hide resolved
@CrCs2O4 CrCs2O4 requested a review from wsxiaoys October 20, 2023 09:55
@wsxiaoys wsxiaoys changed the title Add Ruby Language Support feat: Add Ruby Language Support Oct 20, 2023
@wsxiaoys wsxiaoys enabled auto-merge (squash) October 20, 2023 18:25
@wsxiaoys wsxiaoys merged commit da6109c into TabbyML:main Oct 20, 2023
5 checks passed
TagsConfigurationSync(
TagsConfiguration::new(
tree_sitter_ruby::language(),
tree_sitter_rust::TAGGING_QUERY,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this line be tree_sitter_ruby::TAGGING_QUERY?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been fixed in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby Support
3 participants