-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stop words / repository context support for C/C++ #744
Conversation
@wsxiaoys The PRs to exposing So instead of:
we'll have:
What do you think? Go with |
Go with rev is ok - but you might also considering simply embeds the query scm in https://github.com/TabbyML/tabby/tree/main/crates/tabby-scheduler/queries Like what we did for go / tsx |
c5b6269
to
533a3b1
Compare
@wsxiaoys Since the queries were not modified, I went with the Squashed and pushed the final commit, can you please take a look? |
Could you add a few verification case (through screenshot) in treesitter's query playground" https://tree-sitter.github.io/tree-sitter/playground, like what we did in #813 (comment) |
@wsxiaoys Sorry about the delay, here's the verification for C++: Source code: struct A {
int a;
void method();
};
class B {
void method();
};
void B::method() {}
union C {
A a; B b;
};
void printTest(int a, std::string b) {}
typedef struct Person {
std::string s;
} p; Query:
|
For C: struct A {
int a;
void method();
};
void printTest(int a, std::string b) {}
typedef struct Person {
std::string s;
} p; Query:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, thanks for the effort!
@wsxiaoys Done, should be good to merge now. Also squashed the commits since I had to change the author to my personal email. Should be good to go now. Thanks for the review. |
Requires: