Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various file formats to constants.py #231

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Added various file formats to constants.py #231

merged 3 commits into from
Jun 4, 2024

Conversation

PossiblePanda
Copy link
Contributor

I added various file formats to the constants.py file, including ".dmg", ".s7z", ".cr2", ".jar", ".msi"

@PossiblePanda
Copy link
Contributor Author

I just now realize that some of my additions are debatable, such as .jar could also be an archive file

@CyanVoxel
Copy link
Member

".cr2" would be valuable to have, however both the ARCHIVE_TYPES and PROGRAM_TYPES lists aren't currently being used anywhere. There will be a shift towards using MIME types in favor of these hardcoded lists in the future, however in the meantime it would probably be good to have at least the ".cr2" and ".s7z" extensions added. You're right with the ".jar" ambiguity, in addition to ".dmg" being more closely a disk image type and ".msi" also being in a nebulous space between a program and specifically an installer.

@CyanVoxel CyanVoxel added the Type: Enhancement New feature or request label Jun 3, 2024
@CyanVoxel CyanVoxel self-assigned this Jun 3, 2024
@PossiblePanda
Copy link
Contributor Author

".cr2" would be valuable to have, however both the ARCHIVE_TYPES and PROGRAM_TYPES lists aren't currently being used anywhere. There will be a shift towards using MIME types in favor of these hardcoded lists in the future, however in the meantime it would probably be good to have at least the ".cr2" and ".s7z" extensions added. You're right with the ".jar" ambiguity, in addition to ".dmg" being more closely a disk image type and ".msi" also being in a nebulous space between a program and specifically an installer.

I see, thanks for providing feedback! :)

tagstudio/src/core/constants.py Outdated Show resolved Hide resolved
tagstudio/src/core/constants.py Outdated Show resolved Hide resolved
PossiblePanda and others added 2 commits June 4, 2024 17:06
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
@PossiblePanda
Copy link
Contributor Author

I think I accepted your commits correctly @CyanVoxel , not the best at doing PR's though so let me know if I did it wrong xD

@CyanVoxel
Copy link
Member

I think I accepted your commits correctly @CyanVoxel , not the best at doing PR's though so let me know if I did it wrong xD

You did excellent! And now you've got some more PR practice for the future 😉
Thank you for your work on this!

@CyanVoxel CyanVoxel merged commit 11f0c7f into TagStudioDev:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants