Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi mode search system #232

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Multi mode search system #232

merged 8 commits into from
Jun 3, 2024

Conversation

YoyloNerd
Copy link
Contributor

Adding a dropdown to select between 2 searching modes

  • And (item contains all tags)
  • Or (item contains a tag)

YoyloNerd added 2 commits June 1, 2024 01:14
A way to change the search from requiring all tags to and of the tags
@CyanVoxel CyanVoxel self-assigned this May 31, 2024
@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience labels May 31, 2024
start_win.bat Outdated Show resolved Hide resolved
YoyloNerd and others added 3 commits June 1, 2024 02:19
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
@YoyloNerd YoyloNerd requested a review from CyanVoxel June 2, 2024 14:18
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few comments and nitpicks and this should be good to go:

  1. SEARCH_MODES would be better off inside of enums.py for better readability instead of having situations such as search_mode: int = 0 where it isn't clear to other people what's happening:
class SearchMode(int, enum.Enum):
    """Operational modes for item searching."""
    
    AND = 0
    OR = 1
  1. Remove leftover print statements from library.py
  2. Use "Title Case" for the combo box options

Thank you again for all your work on this!

tagstudio/src/qt/main_window.py Outdated Show resolved Hide resolved
YoyloNerd and others added 3 commits June 3, 2024 11:15
@YoyloNerd YoyloNerd requested a review from CyanVoxel June 3, 2024 09:41
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you again for all your work on this!

@CyanVoxel CyanVoxel merged commit 6e96a0f into TagStudioDev:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants