-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi mode search system #232
Conversation
A way to change the search from requiring all tags to and of the tags
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a few comments and nitpicks and this should be good to go:
SEARCH_MODES
would be better off inside ofenums.py
for better readability instead of having situations such assearch_mode: int = 0
where it isn't clear to other people what's happening:
class SearchMode(int, enum.Enum):
"""Operational modes for item searching."""
AND = 0
OR = 1
- Remove leftover
print
statements fromlibrary.py
- Use "Title Case" for the combo box options
Thank you again for all your work on this!
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thank you again for all your work on this!
Adding a dropdown to select between 2 searching modes