fix(QtDriver): Retain filter on directory refresh #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
CyanVoxel
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Approving this as I've come to agree that this behavior is more coinvent, but I wanted to share a little quirk about doing this that was the reason why I avoided initially avoided it.
When refreshing a library and refiltering with the previous search term like this, you're now creating an additional navigation frame that may just be a duplicate of the previous one, if not one that strangely blends into previous versions of similar search results. Honestly it's not like the navigation frame system is exactly flawless these days anyway, and it's something that needs to be replaced regardless. So, story time aside, you've got a thumbs up from me on this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the filtered query thumbnails in the main window, rather than before where the search would remain in the bar but the filter would be reset to none.
Fixes #482