Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parity): backend for aliases and parent tags #596

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

DandyDev01
Copy link
Contributor

@DandyDev01 DandyDev01 commented Nov 20, 2024

subtags can be added and removed when creating or editing a Tag

  • parent tags would not be listed before
  • parent tags could not be removed before

can exclude tags from the tag search panel

  • it was possible to make a tag parent itself before. Now when selecting a parent tag, the tag being created or edited is excluded from the tag search panel, so it cannot be added as a parent to itself.
  • before when a tag could parent itself, that tag would be corrupted and users would be unable to edit the tag or add it as a parent to another tag (this would corrupt that tag too)

changed how aliases and parents are managed (they use a flowlayout):
image
NOTE: the ui for aliases is being updated to use a table in #534 and parents will be reverted to a list.

  • aliases can be removed and added
  • aliases can be edited

@DandyDev01 DandyDev01 force-pushed the subtag_parent_backend branch from e4f2e7d to dc1cbd0 Compare November 20, 2024 05:33
@DandyDev01 DandyDev01 marked this pull request as ready for review November 20, 2024 05:45
@CyanVoxel CyanVoxel self-assigned this Nov 20, 2024
@CyanVoxel CyanVoxel added Type: Enhancement New feature or request TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Priority: High An important issue requiring attention labels Nov 20, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Nov 20, 2024
@CyanVoxel
Copy link
Member

The backend works seems solid enough to pull! Quick bug I found though, edits to aliases made from the preview panel don't seem to save. Edits made in the tag management window work, and subtag changes work from both panels.

Side note: I like the flow layout for the parent tags!

@CyanVoxel CyanVoxel merged commit 0d166e6 into TagStudioDev:main Nov 21, 2024
5 checks passed
yedpodtrzitko pushed a commit to yedpodtrzitko/TagStudio that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Type: Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants