Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/147 metrics refactor #193

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Refactor/147 metrics refactor #193

merged 7 commits into from
Oct 8, 2024

Conversation

chrisv09
Copy link
Collaborator

@chrisv09 chrisv09 commented Oct 8, 2024

  • Added a new transaction endpoint for retrieving the metrics

@chrisv09 chrisv09 changed the title 147 metrics refactor Refactor/147 metrics refactor Oct 8, 2024
joh748
joh748 previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@joh748 joh748 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculates the financial metrics in the backend and displays them correctly
need to resolve merge conflict

@joh748 joh748 added enhancement New feature or request refactor Improve code quality and removed enhancement New feature or request labels Oct 8, 2024
@joh748 joh748 linked an issue Oct 8, 2024 that may be closed by this pull request
Refactoring From handover #147
Closed
@joh748 joh748 dismissed their stale review October 8, 2024 04:47

merge conflict

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LX6T
LX6T approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@LX6T LX6T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LX6T LX6T merged commit 13e2eac into Taks0708:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LX6T LX6T LX6T approved these changes

@joh748 joh748 joh748 left review comments

Assignees
No one assigned
Labels
refactor Improve code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring From handover
3 participants
@chrisv09 @joh748 @LX6T