Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont use sapi for displaying balances #1744

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Dec 11, 2024

  • Changed native balance module to include one value per validator, in case the account is staking on multiple validators.
  • Adjusted portfolio components to read hotkey from the balance rows instead of fetching them from chain

Copy link
Contributor

github-actions bot commented Dec 11, 2024

🦋 Changeset(s) detected

This PR includes changeset(s) for the following changed packages:

"@talismn/balances"

Not sure what this means? Click here to learn what changesets are.

@0xKheops 0xKheops requested a review from UrbanWill December 11, 2024 10:18
@0xKheops 0xKheops requested review from alecdwm and chidg December 12, 2024 06:36
UrbanWill
UrbanWill previously approved these changes Dec 12, 2024
Copy link
Contributor

@UrbanWill UrbanWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ❤️

Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xKheops 0xKheops merged commit 998e610 into dev Dec 12, 2024
6 checks passed
@0xKheops 0xKheops deleted the feat/bittensor-validator-addresses-in-balances-db branch December 12, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants