Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not invoke getNextPageParam or getPreviousPageParam if there is we have empty pages in the cache #7743

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix(core): do not invoke getNextPageParam or getPreviousPageParam if there is we have empty pages in the cache #7743

merged 2 commits into from
Jul 17, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Jul 17, 2024

fixes #7647

@TkDodo TkDodo marked this pull request as ready for review July 17, 2024 11:03
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 17, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f3c8b34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: f3c8b34

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7743

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7743

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7743

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7743

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7743

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7743

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7743

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7743

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7743

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7743

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7743

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7743

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7743

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7743

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7743

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7743

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7743

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7743

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7743

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7743

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7743

templates

@TkDodo TkDodo merged commit 7edf587 into main Jul 17, 2024
5 checks passed
@TkDodo TkDodo deleted the feature/getNextPageParam-empty-pages branch July 17, 2024 11:09
@mostafatamer11 mostafatamer11 mentioned this pull request Aug 8, 2024
Open
@dn54321 dn54321 mentioned this pull request Aug 8, 2024
Closed
This was referenced Aug 9, 2024
Merged
Merged
@mostafatamer11 mostafatamer11 mentioned this pull request Aug 9, 2024
Open
@dn54321 dn54321 mentioned this pull request Aug 11, 2024
Closed
This was referenced Aug 12, 2024
Closed
Closed
@zntb zntb mentioned this pull request Aug 16, 2024
Merged
@atogura atogura mentioned this pull request Aug 16, 2024
Open
@dn54321 dn54321 mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
1 participant
@TkDodo