Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte-query): ensure compatibility with NodeNext #7825

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

lachlancollins
Copy link
Member

Copy link

nx-cloud bot commented Jul 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a9cba66. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 31, 2024

commit: a9cba66

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7825
pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7825
pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7825
pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7825
pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7825
pnpm add https://pkg.pr.new/@tanstack/query-core@7825
pnpm add https://pkg.pr.new/@tanstack/query-devtools@7825
pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7825
pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7825
pnpm add https://pkg.pr.new/@tanstack/react-query@7825
pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7825
pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7825
pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7825
pnpm add https://pkg.pr.new/@tanstack/solid-query@7825
pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7825
pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7825
pnpm add https://pkg.pr.new/@tanstack/svelte-query@7825
pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7825
pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7825
pnpm add https://pkg.pr.new/@tanstack/vue-query@7825
pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7825

Open in Stackblitz

More templates

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (74f10b7) to head (a9cba66).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7825       +/-   ##
===========================================
+ Coverage   44.61%   88.27%   +43.65%     
===========================================
  Files         185       18      -167     
  Lines        7087      162     -6925     
  Branches     1570       32     -1538     
===========================================
- Hits         3162      143     -3019     
+ Misses       3562       16     -3546     
+ Partials      363        3      -360     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 01e63a5 into main Jul 31, 2024
8 checks passed
@lachlancollins lachlancollins deleted the ts-nodenext branch July 31, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TS moduleResolution: node16 in svelte-query
1 participant