Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-query): add optional queryClient parameter like other hooks #8014

Merged
merged 3 commits into from
Sep 6, 2024
Merged

feat(react-query): add optional queryClient parameter like other hooks #8014

merged 3 commits into from
Sep 6, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Sep 4, 2024

I add optional queryClient parameter like other hooks for consistency

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e9d8529. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 4, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8014

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8014

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8014

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8014

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8014

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8014

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8014

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8014

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8014

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8014

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8014

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8014

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8014

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8014

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8014

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8014

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8014

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8014

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8014

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8014

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8014

commit: e9d8529

@manudeli manudeli marked this pull request as ready for review September 4, 2024 05:28
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (0f86b4d) to head (e9d8529).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8014       +/-   ##
===========================================
+ Coverage   44.51%   81.03%   +36.52%     
===========================================
  Files         195       25      -170     
  Lines        7279      348     -6931     
  Branches     1629       90     -1539     
===========================================
- Hits         3240      282     -2958     
+ Misses       3662       56     -3606     
+ Partials      377       10      -367
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 92.50% <100.00%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 48702e4 into TanStack:main Sep 6, 2024
8 checks passed
@manudeli manudeli mentioned this pull request Sep 6, 2024
Closed
@ypreiser ypreiser mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Merged
Merged
Merged
@jwinr jwinr mentioned this pull request Sep 29, 2024
Merged
This was referenced Sep 30, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo