test(integrations): switch react-scripts to webpack #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit acc09dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
lachlancollins
force-pushed
the
update-deps
branch
from
2e3a569
to
06e5eac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8329 +/- ##
=========================================
+ Coverage 0 45.95% +45.95%
=========================================
Files 0 200 +200
Lines 0 7507 +7507
Branches 0 1713 +1713
=========================================
+ Hits 0 3450 +3450
- Misses 0 3680 +3680
- Partials 0 377 +377
|
lachlancollins
force-pushed
the
update-deps
branch
from
3b032ba
to
17a668b
Compare
lachlancollins
force-pushed
the
update-deps
branch
from
17a668b
to
fbe55f8
Compare
lachlancollins
changed the title
lachlancollins
changed the title
lachlancollins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRA (more specifically react-scripts) installs hundreds of old packages which often have conflicts with newer dependencies. This leads to otherwise simple dependency updates causing major headaches. One temporary solution was #7667, however newer updates are running into infuriating babel resolution issues. This PR cuts out react-scripts and tests directly against webpack.