Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular-query): subscribe to observer outside the Angular zone #8331

Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix(angular-query): subscribe to observer outside the Angular zone #8331

merged 1 commit into from
Nov 23, 2024

Conversation

arnoud-dv
Copy link
Collaborator

Fixes #8115

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fc76130. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 23, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8331

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8331

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8331

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8331

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8331

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8331

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8331

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8331

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8331

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8331

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8331

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8331

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8331

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8331

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8331

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8331

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8331

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8331

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8331

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8331

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8331

commit: fc76130

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (4a2e838) to head (fc76130).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8331       +/-   ##
===========================================
+ Coverage   45.96%   87.13%   +41.16%     
===========================================
  Files         199       18      -181     
  Lines        7501      272     -7229     
  Branches     1717       40     -1677     
===========================================
- Hits         3448      237     -3211     
+ Misses       3676       34     -3642     
+ Partials      377        1      -376
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 87.13% <86.27%> (-1.13%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
---- 🚨 Try these New Features:

@arnoud-dv arnoud-dv marked this pull request as ready for review November 23, 2024 22:37
@arnoud-dv arnoud-dv merged commit 228382f into TanStack:main Nov 23, 2024
8 checks passed
@arnoud-dv arnoud-dv deleted the fix/angular-observer-subscribe branch November 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component tests fail when angular-query is used in the component
1 participant
@arnoud-dv