-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @sveltejs/kit to v2.8.3 [security] #8350
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4471067. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8350 +/- ##
=======================================
Coverage 45.97% 45.97%
=======================================
Files 200 200
Lines 7509 7509
Branches 1716 1714 -2
=======================================
Hits 3452 3452
Misses 3680 3680
Partials 377 377 |
a608391
to
4471067
Compare
This PR contains the following updates:
2.8.2
->2.8.3
GitHub Vulnerability Alerts
CVE-2024-53262
Summary
The static error.html template for errors contains placeholders that are replaced without escaping the content first.
Details
From https://kit.svelte.dev/docs/errors:
This leads to possible injection if an app explicitly creates an error with a message that contains user controlled content that ends up being something like this inside a server handle function:
Uncaught errors cannot be exploited like this, as they always render the message "Internal error".
Escaping the message string in the function that creates the html output can be done to improve safety for applications that are using custom errors on the server.
PoC
None provided
Impact
Only applications where user provided input is used in the
Error
message will be vulnerable, so the vast majority of applications will not be vulnerableCVE-2024-53261
Summary
"Unsanitized input from the request URL flows into
end
, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS)."Details
Source of potentially tainted data is in
packages/kit/src/exports/vite/dev/index.js
, line 437. This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down to line 91 inpackages/kit/src/exports/vite/utils.js
, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.Another source of potentially tainted data (according to Snyk) comes from
packages/kit/src/exports/vite/utils.js
, line 30, col 30 (i.e., theurl
property ofreq
). This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down line 91 inpackages/kit/src/exports/vite/utils.js
, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.PoC
Not provided
Impact
Little to none. The Vite development is not exposed to the network by default. And even if someone were able to trick a developer into executing an XSS against themselves, a development database should not have any sensitive data.
Release Notes
sveltejs/kit (@sveltejs/kit)
v2.8.3
Compare Source
Patch Changes
fix: ensure error messages are escaped (#13050)
fix: escape values included in dev 404 page (#13039)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.