fix: dummy component should return null

TanStack · Sep 19, 2024 · ebe9476 · ebe9476
1 parent f85171d
commit ebe9476
Show file tree

Hide file tree

Showing 15 changed files with 43 additions and 21 deletions.
diff --git a/packages/router-plugin/src/core/code-splitter/compilers.ts b/packages/router-plugin/src/core/code-splitter/compilers.ts
@@ -85,8 +85,6 @@ export function compileCodeSplitReferenceRoute(opts: ParseAstOptions) {
                   path.parentPath.node.arguments[0],
                 )
 
-                let found = false
-
                 const hasImportedOrDefinedIdentifier = (name: string) => {
                   return programPath.scope.hasBinding(name)
                 }
@@ -151,8 +149,6 @@ export function compileCodeSplitReferenceRoute(opts: ParseAstOptions) {
                               `lazyRouteComponent($$splitComponentImporter, 'component')`,
                             )()
                           }
-
-                          found = true
                         } else if (prop.key.name === 'loader') {
                           const value = prop.value
 
@@ -201,8 +197,6 @@ export function compileCodeSplitReferenceRoute(opts: ParseAstOptions) {
                             prop.value = template.expression(
                               `lazyFn($$splitLoaderImporter, 'loader')`,
                             )()
-
-                            found = true
                           }
                         }
                       }
@@ -216,7 +210,7 @@ export function compileCodeSplitReferenceRoute(opts: ParseAstOptions) {
                 // }
                 programPath.pushContainer('body', [
                   template.statement(
-                    `export function TSR_Dummy_Component() {}`,
+                    `export function TSR_Dummy_Component() { return null }`,
                   )(),
                 ])
               }

diff --git a/...outer-plugin/tests/code-splitter/snapshots/destructured-react-memo-imported-component.tsx b/...outer-plugin/tests/code-splitter/snapshots/destructured-react-memo-imported-component.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component'),
   loader: lazyFn($$splitLoaderImporter, 'loader')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/function-declaration.tsx b/packages/router-plugin/tests/code-splitter/snapshots/function-declaration.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/posts')({
   loader: lazyFn($$splitLoaderImporter, 'loader'),
   component: lazyRouteComponent($$splitComponentImporter, 'component')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/...r-plugin/tests/code-splitter/snapshots/imported-default-component-destructured-loader.tsx b/...r-plugin/tests/code-splitter/snapshots/imported-default-component-destructured-loader.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component'),
   loader: lazyFn($$splitLoaderImporter, 'loader')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/imported-default-component.tsx b/packages/router-plugin/tests/code-splitter/snapshots/imported-default-component.tsx
@@ -4,4 +4,6 @@ import { createFileRoute } from '@tanstack/react-router';
 export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/imported.tsx b/packages/router-plugin/tests/code-splitter/snapshots/imported.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component'),
   loader: lazyFn($$splitLoaderImporter, 'loader')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/inline.tsx b/packages/router-plugin/tests/code-splitter/snapshots/inline.tsx
@@ -6,4 +6,6 @@ export const Route = createFileRoute('/')({
 });
 Route.addChildren([]);
 export const test = 'test';
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/random-number.tsx b/packages/router-plugin/tests/code-splitter/snapshots/random-number.tsx
@@ -9,4 +9,6 @@ export const Route = createFileRoute('/')({
   loader: lazyFn($$splitLoaderImporter, 'loader'),
   component: lazyRouteComponent($$splitComponentImporter, 'component')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/react-memo-component.tsx b/packages/router-plugin/tests/code-splitter/snapshots/react-memo-component.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component'),
   loader: lazyFn($$splitLoaderImporter, 'loader')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/react-memo-imported-component.tsx b/packages/router-plugin/tests/code-splitter/snapshots/react-memo-imported-component.tsx
@@ -7,4 +7,6 @@ export const Route = createFileRoute('/')({
   component: lazyRouteComponent($$splitComponentImporter, 'component'),
   loader: lazyFn($$splitLoaderImporter, 'loader')
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/retain-export-component.tsx b/packages/router-plugin/tests/code-splitter/snapshots/retain-export-component.tsx
@@ -25,4 +25,6 @@ export const Route = createFileRoute('/_layout')({
 });
 const HEADER_HEIGHT = '63px';
 export const SIDEBAR_WIDTH = '150px';
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-const.tsx b/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-const.tsx
@@ -28,4 +28,6 @@ const HEADER_HEIGHT = '63px';
 export const SIDEBAR_WIDTH = '150px';
 export const SIDEBAR_MINI_WIDTH = '80px';
 export default Layout;
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-function.tsx b/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-function.tsx
@@ -28,4 +28,6 @@ const HEADER_HEIGHT = '63px';
 export const SIDEBAR_WIDTH = '150px';
 export const SIDEBAR_MINI_WIDTH = '80px';
 export default Layout;
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-loader.tsx b/packages/router-plugin/tests/code-splitter/snapshots/retain-exports-loader.tsx
@@ -12,4 +12,6 @@ export const Route = createFileRoute('/_layout')({
 });
 export const SIDEBAR_WIDTH = '150px';
 export const SIDEBAR_MINI_WIDTH = '80px';
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}
diff --git a/packages/router-plugin/tests/code-splitter/snapshots/useStateDestructure.tsx b/packages/router-plugin/tests/code-splitter/snapshots/useStateDestructure.tsx
@@ -10,4 +10,6 @@ export const Route = createFileRoute('/_libraries/start/$version/')({
     description: startProject.description
   })
 });
-export function TSR_Dummy_Component() {}
+export function TSR_Dummy_Component() {
+  return null;
+}