Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-generator): do not allow "_" as a routeFIleIgnorePrefix #2339

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Sep 15, 2024

Closes #2315

Copy link

nx-cloud bot commented Sep 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 87ce002. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 15, 2024

Open in Stackblitz

More templates

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2339

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2339

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2339

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2339

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2339

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2339

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2339

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2339

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2339

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2339

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2339

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2339

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2339

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2339

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2339

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2339

commit: 87ce002

@SeanCassiere SeanCassiere marked this pull request as ready for review September 15, 2024 01:22
@SeanCassiere SeanCassiere merged commit 7783678 into main Sep 15, 2024
5 checks passed
@SeanCassiere SeanCassiere deleted the generator/restrict-routeFileIgnorePrefix-to-disallow-underscore branch September 15, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: rootRouteNode must not be undefined
1 participant