-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin solid-router
and router-core
#3086
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit d6d2104.
☁️ Nx Cloud last updated this comment at |
The |
LazyRouteOptions, | ||
} from './fileRoute' | ||
|
||
export * from '@tanstack/router-core' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is great export * from '@tanstack/router-core'
. I assume it's a result of moving the ./history.ts file over, and replacing the export * from './history'
, but the @tanstack/router-core
contain a lot more.
> | ||
: TAcc | ||
|
||
export type ParentPath<TOption> = 'always' extends TOption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions can't be extracted this easily - they depend on the AnyRouter now:
router/packages/react-router/src/routeInfo.ts
Lines 62 to 75 in 255f316
export type ParentPath<TRouter extends AnyRouter> = | |
TrailingSlashOptionByRouter<TRouter> extends 'always' | |
? '../' | |
: TrailingSlashOptionByRouter<TRouter> extends 'never' | |
? '..' | |
: '../' | '..' | |
export type CurrentPath<TRouter extends AnyRouter> = | |
TrailingSlashOptionByRouter<TRouter> extends 'always' | |
? './' | |
: TrailingSlashOptionByRouter<TRouter> extends 'never' | |
? '.' | |
: './' | '.' | |
I've copied
react-router
intosolid-router
and replaced most of the React APIs with their Solid equivalent, and also extracted a lot of code that doesn't rely on Solid torouter-core
, which we can later use inreact-router
.solid-router
still has a lot of issues (and seems to be running into solidjs/solid#2352), but a high number of tests are already passing.