Skip to content

Commit

Permalink
Angular examples and dependencies improvements (#5546)
Browse files Browse the repository at this point in the history
* tslib should be a dependency, see:

https://angular.io/guide/angular-package-format#tslib

* ensure angular examples are run as web container on code sandbox

* update lock file

---------

Co-authored-by: Kevin Vandy <kevinvandy656@gmail.com>
  • Loading branch information
arnoud-dv and KevinVandy authored May 12, 2024
1 parent 412c76c commit 2c916d2
Show file tree
Hide file tree
Showing 13 changed files with 58 additions and 22 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ stats.html
*.log
.DS_Store
.cache
.idea
.pnpm-store

package-lock.json
Expand Down
4 changes: 4 additions & 0 deletions examples/angular/basic/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
4 changes: 4 additions & 0 deletions examples/angular/filters/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
4 changes: 4 additions & 0 deletions examples/angular/grouping/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
4 changes: 4 additions & 0 deletions examples/angular/signal-input/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18"
}
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"@types/node": "^20.12.7",
"jsdom": "^24.0.0",
"knip": "^5.10.0",
"ng-packagr": "^17.3.0",
"nx": "^18.3.4",
"prettier": "^4.0.0-alpha.8",
"prettier-plugin-svelte": "^3.2.3",
Expand All @@ -72,7 +71,6 @@
"rollup-plugin-visualizer": "^5.12.0",
"sherif": "^0.8.4",
"size-limit": "^11.1.2",
"tslib": "^2.6.2",
"typescript": "5.4.5",
"vitest": "^1.5.2"
}
Expand Down
6 changes: 4 additions & 2 deletions packages/angular-table/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,12 @@
"build:types": "tsc --emitDeclarationOnly"
},
"dependencies": {
"@tanstack/table-core": "workspace:*"
"@tanstack/table-core": "workspace:*",
"tslib": "^2.6.2"
},
"devDependencies": {
"@angular/core": "^17.3.1"
"@angular/core": "^17.3.1",
"ng-packagr": "^17.3.0"
},
"peerDependencies": {
"@angular/core": ">=17"
Expand Down
35 changes: 17 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2c916d2

Please sign in to comment.