fix: column getIsVisible works for parent group columns (#5380)

* fix: column getIsVisible works for parent group columns * update snapshot
TanStack · Feb 28, 2024 · 6792327 · 6792327
1 parent c620b65
commit 6792327
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 33 deletions.
diff --git a/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap b/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap
@@ -4,13 +4,9 @@ exports[`useReactTable > can toggle column visibility > 0 - after toggling all o
 {
   "footers": [
     [],
-    [],
-    [],
   ],
   "headers": [
     [],
-    [],
-    [],
   ],
   "rows": [
     [],
@@ -304,20 +300,6 @@ exports[`useReactTable > can toggle column visibility > 3 - after toggling More
         "1",
       ],
     ],
-    [
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-    ],
     [
       [
         "Name",
@@ -340,20 +322,6 @@ exports[`useReactTable > can toggle column visibility > 3 - after toggling More
         "1",
       ],
     ],
-    [
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-    ],
     [
       [
         "firstName",

diff --git a/packages/table-core/src/features/Visibility.ts b/packages/table-core/src/features/Visibility.ts
@@ -178,7 +178,12 @@ export const Visibility: TableFeature = {
       }
     }
     column.getIsVisible = () => {
-      return table.getState().columnVisibility?.[column.id] ?? true
+      const childColumns = column.columns
+      return (
+        (childColumns.length
+          ? childColumns.some(c => c.getIsVisible())
+          : table.getState().columnVisibility?.[column.id]) ?? true
+      )
     }
 
     column.getCanHide = () => {