Trigger recalculation on every update when not scrolling #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -391,7 +413,7 @@ export class Virtualizer<TScrollElement = unknown, TItemElement = unknown> { | |||
| }, | |||
| ) | |||
|
|
|||
| private calculateRange = memo( | |||
| calculateRange = memo( | |||
There was a problem hiding this comment.
I'm ecstatic that you are trying to solve this, because my team recently just ran head first into this exact issue. My main question with this approach, I think, is why can't we just have measure (which is already public) call calculateRange as part of its implementation. At the moment, it already doesn't seem to be doing what it semantically says it should be doing (from what I can tell{).
There was a problem hiding this comment.
Hi, i think we need to re-thing measure, now it's only clears itemMeasurementsCache and trigger update so most cases it will not measure anything. When we merge #405 with adding support observing elements with ResizeObserver i think we could drop it.
kuanoni
added a commit
to kuanoni/react-security-badging-system
that referenced
this pull request
Nov 4, 2022
Fix this when these pulls go through. TanStack/virtual#363 TanStack/virtual#414
piecyk
force-pushed
the
fix/calc-range-when-not-scrolling
branch
from
ae755a7 to
c1049e3
Compare
piecyk
force-pushed
the
fix/calc-range-when-not-scrolling
branch
from
c1049e3 to
57f225c
Compare
kuanoni
added a commit
to kuanoni/react-security-badging-system
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363
suppress #403