Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves readability #826

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Improves readability #826

merged 4 commits into from
Sep 16, 2024

Conversation

schalkventer
Copy link
Contributor

@schalkventer schalkventer commented Sep 2, 2024

I had to re-read this sentence a several times until I understood the meaning. Perhaps adding punctuation and chaning the grammar sligthly improves readability?

I had to re-read this sentence a several times until I understood the meaning. Perhaps adding parenthesis improves readability?
Copy link

nx-cloud bot commented Sep 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f5b7e87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 2, 2024

Open in Stackblitz

More templates

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@826

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@826

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@826

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@826

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@826

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@826

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@826

commit: f5b7e87

docs/api/virtualizer.md Outdated Show resolved Hide resolved
@schalkventer
Copy link
Contributor Author

@piecyk: See changes above.

@schalkventer schalkventer requested a review from piecyk September 12, 2024 04:45
@piecyk piecyk merged commit 00f66eb into TanStack:main Sep 16, 2024
5 checks passed
@piecyk
Copy link
Collaborator

piecyk commented Sep 16, 2024

@schalkventer thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants