Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

prevent from NPE, add a multi get returning list of pair of (key maps) #10

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

worldline-messaging
Copy link

if(rec.bins!=null) { to prevent from NullPointerException ( you can pass an empty set as parameter of the query )

multiQueryL is better when you want to keep the order of the keys passed as parameter. With a map you loose the order in the result.

For the WriteSettings, i prefere to send key by default.

Blocking is just a question of choice.

add a multi get returning list of pair key maps
add the scanall functionality
do block when we reach max commands
@soro
Copy link

soro commented Feb 9, 2015

That null check actually seems to be necessary - should probably have been spelled out in their docs that they simply return a null instead of an empty collection in case you request no bins.
I think it makes more sense to add a method that takes a CanBuildFrom instead of a concrete List instance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants