This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
OPER-5924 Forward-port fix for asset prefix w/ trailing slash #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanbrent
force-pushed
the
oper-5924/forward-port-path-fix
branch
from
5060019
to
50c6bd5
Compare
The local filesystem glob in `AssetSync::Storage#get_local_files` uses fuzzy matching when config.prefix is present. This can present a problem in some cases, as it doesn't allow for distinguishing between (e.g.) a folder called `assets/` and another folder called `assets-temp/`. A situation could arise where the latter folder has thousands/millions of files and we mistakenly publish local-only files, or worse we could clobber another directory in the bucket managed in a completely different context. This change allows developers to be more specific in their `config.prefix` by using a trailing slash for their folder name.
alanbrent
force-pushed
the
oper-5924/forward-port-path-fix
branch
from
50c6bd5
to
9fc6c48
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local filesystem glob in
AssetSync::Storage#get_local_filesuses fuzzy matching when config.prefix is present. This can present a problem in some cases, as it doesn't allow for distinguishing between (e.g.) a folder calledassets/and another folder calledassets-temp/. A situation could arise where the latter folder has thousands/millions of files and we mistakenly publish local-only files, or worse we could clobber another directory in the bucket managed in a completely different context.This change allows developers to be more specific in their
config.prefixby using a trailing slash for their folder name.Pre-Release Requirements
Release Process
Given the forked nature of the repo, this is how I plan to "release" this.
v2.15.1.1tagNotes
There is an upstream PR (AssetSync#425) with this change. Hopefully it's approved and released, so then we can stop maintaining a forked version of this gem.