Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Mova M1 dreame.vacuum.r2380 #607

Open
Tasshack opened this issue Jun 22, 2024 · 43 comments
Open

Support For Mova M1 dreame.vacuum.r2380 #607

Tasshack opened this issue Jun 22, 2024 · 43 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@Tasshack
Copy link
Owner

Describe the bug
Model is in supported devices list but not in the config flow therefore cannot be added to the HA.

#604

@Tasshack Tasshack added bug Something isn't working question Further information is requested labels Jun 22, 2024
@Tasshack Tasshack self-assigned this Jun 22, 2024
@KingDispo
Copy link

As you recommended: removing the "#" from model number in https://github.com/Tasshack/dreame-vacuum/blob/dev/custom_components/dreame_vacuum/config_flow.py#L123 and restarting HA worked for me. Could now add the Mova M1.

image

But then next problem occours:

image

Maybe thats why you remove MOVA M1 - dreame.vacuum.r2380?

@Tasshack
Copy link
Owner Author

@KingDispo Can you share the full HA log?

@KingDispo
Copy link

KingDispo commented Jun 22, 2024

uploading the Full HA log ...

image

@Tasshack
Copy link
Owner Author

Can you change the log level, restart the HA and send me the log output again?

logger:
  default: warn
  logs:
    custom_components.dreame_vacuum: debug

@KingDispo
Copy link

KingDispo commented Jun 22, 2024

Did that.

@Tasshack
Copy link
Owner Author

Can you override this file from custom_components/dreame_vacuum/dreame/protocol.py, restart the HA and send me the log output again?

protocol.zip

@KingDispo
Copy link

KingDispo commented Jun 23, 2024

Here is the new log.

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 23, 2024

Overriding these two files will fix the issue and integration should start but I have remembered why I have opt out this model and that is because of it's TOF Lidar sensor. It may require additional processing like on the VSLAM vacuums so I am not sure map will render correctly when integration has been successfuly started after this fix.

dreame.zip

@KingDispo
Copy link

KingDispo commented Jun 23, 2024

Thanks, but unfortunally even after overriding the two files the problem still exists:

image

@Tasshack
Copy link
Owner Author

It did go further this time and this should fix the new error.
device.zip

We need to keep continue like this until integration been started successfully.

@KingDispo
Copy link

KingDispo commented Jun 23, 2024

looks much better now!

image

@Tasshack
Copy link
Owner Author

None of the remaining errors are related to this integration and it looks to be working now.
Can you test rest of the functions from HA and compare map image with the app to check it correctly renders?

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 23, 2024

I can rather check compatibility myself make necessary fixes to make it device fully supported if you prefer to give your device access to my dreame account over device sharing feature of the app.

@KingDispo
Copy link

Map renders correctly, but it changes every seconds to a non good rendered map.
image

Here is a video:

Aufzeichnung.2024-06-23.125414.mp4

I can not controll the robot via HA.

image
If i click on start or click on go to home nothing happens.

@KingDispo
Copy link

Yes, i can share the robot if you want.

@Tasshack
Copy link
Owner Author

Yes, i can share the robot if you want.

My userid is BP428398. I will fix all the issues and let you know when it is ready to use.

@KingDispo
Copy link

KingDispo commented Jun 23, 2024 via email

@KingDispo
Copy link

After some tests i can confirm: controlling the robot via home assistant seems to work. I'm happy after some first tests.

@Tasshack
Copy link
Owner Author

Map is not working properly, I am afraid tof laser has some special processing needs that i have to implement now.

@Tasshack
Copy link
Owner Author

Can you remove the device from your HA until I finish my work because currently it is interfering with the cloud data by not working correctly?

@KingDispo
Copy link

KingDispo commented Jun 24, 2024 via email

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 24, 2024

Thanks, but it still sends a new map data to the integration every second. I am not sure this is a bug from its firmware or a normal behaviour but I have never seen this on any other robot ever.
I have found out why saved maps and rooms are not listing in the HA and fixed it but I still need to address the issue of vacuum sending the map data constantly even when it is sleeping and integration cannot handle them correctly.

Normally it should have been looked like this.
Capture

@Tasshack
Copy link
Owner Author

Capture

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 24, 2024

Also I have never seen a device with negative device and map ids. Not sure what is going on but looks like Dreame has messed up badly when making this device.
That is what I have exactly thought this may happen when I am opting out of this device from the supported devices list.

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 24, 2024

@KingDispo I see that your device never goes to sleep mode and also it is acting like it is moving all the time by sending a new map data every second indicates that there is something wrong with it.
Normally integration gets an initial map data from the device and device sends partial map data when the map data changes which contains only the changed parts of the map. That means every partial map data must be parsed within their frame order but the integration/app may have some missing frames before the latest partial map. When that happens integration/app requests that specific partial frame from device to fill the gap and parse rest of the partial frames.
Your device skips a frame after the initial map data when sending a partial map and it does not respond to anything when integration requests the missing frame from it (thats why map gets blurred because device will become unavailable) so integration cannot parse the consecutive frames and there is nothing I can do to fix that.

Is it possible for you to hard reset the device and install it again to check the issue has been resolved, otherwise I am not sure what to do here.

@KingDispo
Copy link

KingDispo commented Jun 24, 2024 via email

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 24, 2024

It should reset when you hold wifi button until it reboots.
Normally all dreame devices reboot at 03:00 local time so I am pretty sure rebooting won't fix it.

@KingDispo
Copy link

KingDispo commented Jun 25, 2024 via email

@Tasshack
Copy link
Owner Author

It is not possible to use the integration wihout map with dreamehome account also you cannot use room cleaning feature without map.

@Tasshack
Copy link
Owner Author

Can you share the device with my account again so I can check any changes?

@Tasshack
Copy link
Owner Author

Tasshack commented Jun 25, 2024

I will also check the app source code as last resort to see how actually app handles the situation. I hope I can find a solution there.

@KingDispo
Copy link

KingDispo commented Jun 25, 2024 via email

@KingDispo
Copy link

Because of performance issues in HA i deleted the robot in home assistant - now everythink is fine again. Unfortunally without the Mova M1 (in HA)

@Tasshack
Copy link
Owner Author

Because of performance issues in HA i deleted the robot in home assistant - now everythink is fine again. Unfortunally without the Mova M1 (in HA)

It's normal due to integration is trying to keep up with the vacuum sending a new map data to be processed every three seconds.
I could't had time to look at the issue again but I hope I can find some time in a couple of days.

At the worst case, I can disable partial map processing for this device and map won't be refreshing at the rate is should be but at least you will be able to use the integration. Adding that feature to the integration also will take time and I am pretty sure this is a firmware bug that will be fixed as soon as Dreame realizes that devices won't go to sleep so I prefer not to make unnecessary changes to the integration yet.

@KingDispo
Copy link

Thanks for your help and your integration. I sent the device back to the seller. Looking for another vacuum with with fewer problems

@Tasshack
Copy link
Owner Author

Tasshack commented Jul 7, 2024

Thanks for your help and your integration. I sent the device back to the seller. Looking for another vacuum with with fewer problems

Sorry for that, now I am never be able to fix the issue and no choice to keep device unsupported.

@pezlin
Copy link

pezlin commented Aug 22, 2024

I have just purchased a Dreame Mova M1. Can I support in any way?

@Tasshack
Copy link
Owner Author

I have just purchased a Dreame Mova M1. Can I support in any way?

Have you read the whole converstation?

@pezlin
Copy link

pezlin commented Aug 22, 2024

I have just purchased a Dreame Mova M1. Can I support in any way?

Have you read the whole converstation?

Yes, and to my understanding the issue with the map is still unresolved due to that you had no device to test with. I haven't installed the integration yet but I noticed in the instructions that it was possible to choose "Without map".

@Tasshack
Copy link
Owner Author

I have removed it from supported devices list due to this bug so you won't be able to add this device to your HA right now.

I can take a look at the issue again if you share your device with my account but I really don't have much time for that right now.

Also I am still not sure that I need to take action about this because the behaviour of the device seems very wrong and probably due some bug that will be fixed by the Dreame soon.

Can you check from the app that your device goes to sleep when charging is completed or is it always stays idle?

@pezlin
Copy link

pezlin commented Aug 22, 2024

I can only see that it says Charging completed in the app. Not sure how to see if it goes to sleep or is idle.

I installed it yesterday and got a new firmware update installed so perhaps this issue is solved.

@Tasshack
Copy link
Owner Author

Probably fixed, so you can give it a shot by uncommenting the model line from config_flow.py

@pezlin
Copy link

pezlin commented Aug 23, 2024

Seems to be working now. At least when doing a quick test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants