Refactor: Get rid of LazyUserList (port functionality to pytrakt)

[glensc]

Feature description

Use case

There's still some code left that's hacking pytrakt internals:

• PlexTraktSync/plextraktsync/trakt_list_util.py

  Lines 7 to 25 in acd6b43

  	class LazyUserList(UserList):
  	@get
  	def get_items(self):
  	data = yield f"lists/{self.trakt}/items"
  	for item in data:
  	if "type" not in item:
  	continue
  	item_type = item["type"]
  	item_data = item.pop(item_type)
  	self._items.append((item_type + "s", item_data["ids"]["trakt"]))
  	yield self._items
  	@classmethod
  	@get
  	def _get(cls, title, id):
  	data = yield f"lists/{id}"
  	ulist = cls(creator=data["user"]["username"], **data)
  	ulist.get_items()
  	yield ulist

Plan is to get rid of it, add missing functionality to pytrakt if needed.

[glensc]

@simonc56 as I understand the lazy userlist exists for two purposes:

1. not to create Movie, Episode etc objects
2. data path is different data = yield f"lists/{self.trakt}/items"

I think the first point was the original purpose (is that reason still valid?), but second difference came from evolution. should pytrakt be changed to use "lists/{trakt}/items" as well? it seems have changed in 7bde749

or add new entity there just for operating "lists", and operations would be only read methods

[simonc56]

LazyUserlist is a kind of hack inspired by LazyEpisode, created to fetch trakt lists faster and avoid hiting rate limit :

• Use LazyUserList to fetch Trakt Lists faster #493
• Fails to retrive Trakt List, if it has Episodes Instead of Shows #489 (comment)

About items path, I don't remember anything. Maybe it's changed and needs to be updated.

[simonc56]

should pytrakt be changed to use "lists/{trakt}/items" as well? it seems have changed in 7bde749

As explained here, fetching a list with its trakt id is "better" because allows to get user lists AND official lists. Maybe you could create a List class (for all kind of lists) instead of the current Userlist (for lists created by trakt users).

[glensc]

List is reserved word (and UserList is also from standard library), but yeah new api seems easier

[glensc]

I'll use PublicList for name:

You must use an integer id, and only public lists will return data.

• https://trakt.docs.apiary.io/#reference/lists/popular/get-list

[glensc]

Started something:

• Feature: Add PublicList class glensc/python-pytrakt#43

how to find other list types than Movies?

[simonc56]

how to find other list types than Movies?

A trakt list can contain movies, shows, seasons, episodes and people.

But Plex playlist cannot contain such various content.
Only movies and episodes :

• Add tv episodes to playlist sync trakt->plex #76
• Liked Lists from Trakt #1135 (comment)

And Plex collections can contain movies or shows.