Use LazyUserList to fetch Trakt Lists faster #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonc56
force-pushed
the
get-trakt-lists-faster
branch
from
358e21f
to
8f02ab0
Compare
Repository owner
locked as resolved and limited conversation to collaborators
Jan 11, 2022
glensc
reviewed
Oct 27, 2022
|
|
||
| @classmethod | ||
| @get | ||
| def _get(cls, title, creator): |
There was a problem hiding this comment.
_get override should not be needed after glensc/python-pytrakt#3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates LazyUserList class being inherited from trakt UserList class but without requesting each item of the list to Trakt API.
Fetching Trakt lists should be much faster and not crashing if above 1000 items (GET rate limit of trakt API).
fixes #489