Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Conditional library walk #1040

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Feature: Conditional library walk #1040

merged 3 commits into from
Sep 5, 2022

Conversation

simonc56
Copy link
Collaborator

@simonc56 simonc56 commented Sep 4, 2022

Do not walk across Plex libraries if it's not needed

@glensc glensc changed the title Conditional library walk Feature: Conditional library walk Sep 5, 2022
@glensc
Copy link
Collaborator

glensc commented Sep 5, 2022

wouldn't it be simpler to skip calling runner.sync if nothing to walk? i.e then wouldn't need to add the condition in Sync class and in sync command. i.e check the state and return early in command/sync.py

@simonc56
Copy link
Collaborator Author

simonc56 commented Sep 5, 2022

Nothing to walk but something to sync 😉

@glensc
Copy link
Collaborator

glensc commented Sep 5, 2022

Nothing to walk but something to sync 😉

please explain.

@simonc56
Copy link
Collaborator Author

simonc56 commented Sep 5, 2022

#1019

@simonc56 simonc56 self-assigned this Sep 5, 2022
@simonc56 simonc56 merged commit 1732f82 into Taxel:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonc56 simonc56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonc56 @glensc