Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Skip episodes from Specials #1674

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Dec 23, 2023

As trakt doesn't have specials no point to make trakt query for matching specials.

$ ./plextraktsync.sh sync --id=21459
INFO     Sync Episodes: ['2016-08-31']                                                                                                        
WARNING  Skipping Special: Viimane võmm/s00e01/2016-08-31 (2016)                                                                              
Processing episodes 100% ━━━━━━━━━━━━━━━━━━━━━ 1/1  [ 0:00:00 < 0:00:00 , ? it/s ]
INFO     Completed full sync in 0.0 seconds     

Recommended config to filter out those messages:

  filter:
    - level: WARNING
      message: "Skipping Special: "

Fixes: #1033

See also:

@glensc
Copy link
Collaborator Author

glensc commented Dec 23, 2023

My test episode from specials is actually marked as Season 1...

Relevant inspect info:

Media.Type: 'episode'
Media.Guid: 'com.plexapp.agents.thetvdb://293454/5/2016-08-31?lang=en'

update: messed up episode vs season: 13396a7

@glensc
Copy link
Collaborator Author

glensc commented Dec 23, 2023

Actually, there are specials in trakt:

should this be configurable then?

@glensc glensc requested a review from simonc56 December 27, 2023 11:27
@glensc glensc marked this pull request as ready for review December 27, 2023 11:27
Copy link
Collaborator

@simonc56 simonc56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks the sync of specials episodes.
It doesn't solve the #1033 which is asking for an option. Where is the option ?

@glensc
Copy link
Collaborator Author

glensc commented Dec 28, 2023

so, when assigned as reviewer, was expecting your comment how to handle this.

seems there are specials in trakt, but not always. basically you can come up with anything and put it as special in your library. i.e. promotion video, trailer.

@simonc56
Copy link
Collaborator

simonc56 commented Dec 28, 2023

so, when assigned as reviewer, was expecting your comment how to handle this.

Keep it as a draft then.
#1033 (comment)

seems there are specials in trakt, but not always. basically you can come up with anything and put it as special in your library. i.e. promotion video, trailer.

No, those are Extra, not Specials.
Read :

@glensc glensc marked this pull request as draft December 28, 2023 15:23
@glensc
Copy link
Collaborator Author

glensc commented Dec 29, 2023

what about e00? is it special or extra?

WARNING  Sherlock/s03e00/Episode 0 (None): Skipping <PlexGuid:com.plexapp.agents.thetvdb://176941/3/0?lang=en> not found on Trakt

@simonc56
Copy link
Collaborator

There is no episode 0.

@glensc
Copy link
Collaborator Author

glensc commented Dec 29, 2023

but it exists:

update:

listed in tvdb as s00e04:

I guess it appeared around s03, i.e before s03e01 release, hence internet used such naming

update 2:

seems to be listed as movie in trakt:

update 3:

but also as special:

@simonc56
Copy link
Collaborator

simonc56 commented Dec 29, 2023

Yes, providers tmdb and tvdb have different rules for episodes order.
Sometimes movies declined from a tv show are listed as special episodes in a provider, and listed as movies in other provider.
Also, sometimes seasons are splitted in 2 differents shows in one provider and remain in 1 show in another provider.
Such a mess 😄

We had an issue about it last year with Naruto Shippuden : #996 (comment)
For PTS, as readme says, tmdb order takes precedence because that's the trakt source db.

seems to be listed as movie in trakt:

but also as special:

Strange to be listed twice.
I think the movie should be removed from tmdb (7m duration ?)

@glensc
Copy link
Collaborator Author

glensc commented Jan 15, 2024

it really is 8 mins long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Option to skip Specials (Season 0)
2 participants