-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Pull Request for Support for Plex Movie Scanner. #83
Conversation
since you created a new PR, close the previous one ("close pull request" button at the bottom) |
there's no point to have two commits, especially as you lost any authorship information. squash to one commit and force push can help to resolve this. |
I'm failing you a bit here, very sorry. I might be out of my depth a bit on that ... I haven't done it before and would hate to cause more issues that I help solve. If my quick google search is close to right ... do I: git rebase -i HEAD~2 Which I did try ... but it didn't seem to change anything. |
Code Cleanup from original PR#82
3b40a00
to
ad2e567
Compare
OK, I figured it out. Thanks for your patience. |
Edited PR body (that you replaced the previous PR is not relevant in PR context), and added a link to issue at hand. |
Not sure which one is better/accurate/etc, but there's similar PR with content: |
@wampa1 can you instead test the other PR works fine for you: |
I'll check it out tonight. Thankful that you think of me! |
@wampa1 don't forget to re-install python dependencies, they have been updated but I don't think there's a mechanism in place to check that they are up to date. |
I wrote a fallback matcher but ... as I'm not a contributor (and work mostly in non open source repositories), I'm not 100% sure I know how to submit a pull request for it. Happy to contribute though if you like.
I'm also not a Python guy so ... it could use someone else's eyes on it.
I spent my whole day looking for an up to date app to sync the watched status of my Plex library (I reorganized it and everything was "unwatched" again). This was definitely the most promising and with my small update, it did work for my large library.
Fixes: #56