Skip to content

Commit

Permalink
ci(validate): drops support for node 16 (#4)
Browse files Browse the repository at this point in the history
This PR drops support for Node 16, which is at EOL. It also extracts all
setup for script-running actions into a composite action so that I don't
have to maintain things in multiple places.
  • Loading branch information
Tbhesswebber authored Jan 13, 2024
1 parent bd1d9c3 commit 93dc9ca
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 31 deletions.
21 changes: 21 additions & 0 deletions .github/composite-workflows/pnpm-script-base/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Base Pnpm Script Action
description: Setup everything to run a pnpm script
inputs:
node-version:
description: the version of Node to use
required: true

runs:
using: composite
steps:
- name: Install dependencies
uses: pnpm/action-setup@v2
with:
version: 8
run_install: |
- recursive: true
- name: Setup Node.js
uses: actions/setup-node@v3
with:
cache: "pnpm"
node-version: ${{ matrix.node-version }}
41 changes: 10 additions & 31 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: CI
on:
push:
pull_request:
branches:
- release/v*
- main
Expand All @@ -11,59 +11,38 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["16.x", "18.x", "20.x"]
node-version: ["18.x", "20.x"]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
uses: pnpm/action-setup@v2
- name: Setup Script Runner
uses: ./.github/composite-workflows/pnpm-script-base
with:
version: 8
run_install: |
- recursive: true
- name: Setup Node.js
uses: actions/setup-node@v3
with:
cache: "pnpm"
node-version: ${{ matrix.node-version }}
- run: pnpm run lint
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["16.x", "18.x", "20.x"]
node-version: ["18.x", "20.x"]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
uses: pnpm/action-setup@v2
with:
version: 8
run_install: |
- recursive: true
- name: Setup Node.js
uses: actions/setup-node@v3
- name: Setup Script Runner
uses: ./.github/composite-workflows/pnpm-script-base
with:
cache: "pnpm"
node-version: ${{ matrix.node-version }}
- run: pnpm test
compile:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["16.x", "18.x", "20.x"]
node-version: ["18.x", "20.x"]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
uses: pnpm/action-setup@v2
with:
version: 8
run_install: |
- recursive: true
- name: Setup Node.js
uses: actions/setup-node@v3
- name: Setup Script Runner
uses: ./.github/composite-workflows/pnpm-script-base
with:
cache: "pnpm"
node-version: ${{ matrix.node-version }}
- run: pnpm run compile

0 comments on commit 93dc9ca

Please sign in to comment.