Add a minimum rustc version policy #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
force-pushed
the
minimum-rustc-version
branch
from
3c59d26 to
5b7d40e
Compare
killercup
reviewed
Jun 6, 2018
README.md
Outdated
| ## StructOpt rustc version policy | ||
|
|
||
| - Minimum rustc version modification must be specified in the [changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) and in the [travis configuration](https://github.com/TeXitoi/structopt/blob/master/.travis.yml). | ||
| - Contributors can increment minimum rustc version without any justification if the new version is required by the latest version of one of StructOpt's depedencies (`cargo update` will not ffail on StructOpt). |
README.md
Outdated
| - Minimum rustc version modification must be specified in the [changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) and in the [travis configuration](https://github.com/TeXitoi/structopt/blob/master/.travis.yml). | ||
| - Contributors can increment minimum rustc version without any justification if the new version is required by the latest version of one of StructOpt's depedencies (`cargo update` will not ffail on StructOpt). | ||
| - Contributors can increment minimum rustc version if the library user experience is improved. | ||
|
|
There was a problem hiding this comment.
So it's cool to bump the min required rustc version between structopt 1.2.3 to 1.2.4? I'd probably try and do that in minor versions only. This is also the policy in some other crates
There was a problem hiding this comment.
Right now, we are in 0.x version, thus I don't want to do a breaking change version to upgrade rustc.
But, after 1.0.0 I think that following the minor rule would be the way to go.
TeXitoi
force-pushed
the
minimum-rustc-version
branch
2 times, most recently
from
7a6ed8f to
b412659
Compare
TeXitoi
force-pushed
the
minimum-rustc-version
branch
from
b412659 to
70a9958
Compare
|
v0.2.10 published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #115
@zigguratvertigo @hcpl @killercup OK?