Update to Kotlin 1.0.0. + Json Remote Command #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskeith
requested changes
Oct 22, 2020
firebase/src/main/java/com/tealium/remotecommands/firebase/FirebaseConstants.java
Show resolved
Hide resolved
firebase/src/main/java/com/tealium/remotecommands/firebase/FirebaseConstants.java
Outdated
Show resolved
Hide resolved
* Fixes per PR feedback * Readme copyright date update * remove import Co-authored-by: jameskeith <james.keith@tealium.com>
* Update to handle items param + format correctly for firebase * Cleanup imports * Refactor for single product item * Add switch default log stmt * Rename items format methods * Remove deprecated FB event/param constants per review feedback * Code review updates
jameskeith
added a commit
that referenced
this pull request
Nov 10, 2020
* Update to Kotlin 1.0.0. + Json Remote Command * Correct import for constants * Fixes per PR feedback (#6) * Fixes per PR feedback * Readme copyright date update * remove import Co-authored-by: jameskeith <james.keith@tealium.com> * Formatting items param for FB (#8) * Update to handle items param + format correctly for firebase * Cleanup imports * Refactor for single product item * Add switch default log stmt * Rename items format methods * Remove deprecated FB event/param constants per review feedback * Code review updates Co-authored-by: jameskeith <james.keith@tealium.com> Co-authored-by: jameskeith <james.keith@tealium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.