Feature/#120 #122
Open
Feature/#120 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongchandev
requested review from
GayeongKimm and
suw0n
and removed request for
GayeongKimm
GayeongKimm
reviewed
Sep 26, 2024
There was a problem hiding this comment.
에러 로깅이 필요하다면 log보단 exception처리를 하는게 나을것 같아요
There was a problem hiding this comment.
mealData에서 null처리 해야 nullPointException이 안 뜰것 같아요
There was a problem hiding this comment.
null이 들어올 일이 없을 듯 합니다
There was a problem hiding this comment.
다른 메소드는 다 stream형식으로 하였는데 getSchedules메소드만 stream을 적용 안 한 이유가 있나요?
There was a problem hiding this comment.
로직이 복잡해서 stream을 쓰면 가독성이 안좋아질 것 같아서 사용 안했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.