fix & test: 중복 가입 오류 해결

orElse -> orElseGet
Team-J9 · Jul 19, 2024 · 0f240ba · 0f240ba
1 parent 705c371
commit 0f240ba
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/main/java/com/j9/bestmoments/service/MemberService.java b/src/main/java/com/j9/bestmoments/service/MemberService.java
@@ -38,9 +38,8 @@ public Member findById(UUID id) {
 
     @Transactional
     public Member findOrSaveByOAuthInfo(OAuthUserInfoDto oAuth2UserInfo) {
-        Member member = memberRepository.findByOauthProviderAndOauthId(oAuth2UserInfo.provider(), oAuth2UserInfo.id())
-                .orElse(this.create(oAuth2UserInfo));
-        return memberRepository.save(member);
+        return memberRepository.findByOauthProviderAndOauthId(oAuth2UserInfo.provider(), oAuth2UserInfo.id())
+                    .orElseGet(() -> memberRepository.save(this.create(oAuth2UserInfo)));
     }
 
     private Member create(OAuthUserInfoDto oAuthUserInfoDto) {

diff --git a/src/test/java/com/j9/bestmoments/service/MemberServiceTest.java b/src/test/java/com/j9/bestmoments/service/MemberServiceTest.java
@@ -83,8 +83,14 @@ void findOrSaveByOAuthInfo_Find() {
                 null,
                 null
         );
-        Member foundMember = memberService.findOrSaveByOAuthInfo(dto);
-        Assertions.assertEquals(member1, foundMember);
+        Page<Member> previousMembers = memberService.findAll(PageRequest.of(0, 100));
+
+        memberService.findOrSaveByOAuthInfo(dto);
+        Page<Member> currentMembers = memberService.findAll(PageRequest.of(0, 100));
+
+        long previousMembersCount = previousMembers.stream().count();
+        long currentMembersCount = currentMembers.stream().count();
+        Assertions.assertEquals(previousMembersCount, currentMembersCount);
     }
 
     @Test