Fix/#60 출석 관련 세부 로직 추가 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgmJun
commented
Jul 19, 2023
Comment on lines
22
to
26
| public static ChallengeLevelType findByLevel(int level) { | ||
| return Arrays.stream(values()) | ||
| .filter(t -> t.level == level) | ||
| .findFirst() | ||
| .orElse(LEVEL_FIVE); |
There was a problem hiding this comment.
네이밍 get(int level) 어떤가요?!
There was a problem hiding this comment.
네이밍 get(int level) 어떤가요?!
get은 Getter메서드 느낌이 강해서 find 는 어떠신가요?
Comment on lines
30
to
45
| public void checkAttendance(Article article, Member member) { | ||
| if (checkIsNotAttended(member)) { | ||
| if (checkIsTodayArticle(article, member)) { | ||
| attendanceRepository.save(Attendance.newInstance(member)); | ||
|
|
||
| int attendanceCheckCount = attendanceRepository.findAttendancesByMember(member).size(); | ||
| member.getChallenge().levelUp(attendanceCheckCount); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private boolean notAttended(Member member) { | ||
| Optional<Attendance> firstMemberAttendance = findMemberLastAttendance(member); | ||
| if (firstMemberAttendance.isEmpty()) { | ||
| private boolean checkIsTodayArticle(Article article, Member member) { | ||
| WeekAndDay weekAndDay = MemberServiceUtils.findMemberWeekAndDay(member); | ||
|
|
||
| return weekAndDay.equals(WeekAndDay.of(article.getWeek(), article.getDay())); | ||
| } |
There was a problem hiding this comment.
boolean 메서드는 is 로 시작하는거 어떤가요?!
There was a problem hiding this comment.
boolean 메서드는 is 로 시작하는거 어떤가요?!
isPresent() 예시를 듣고 인정하였읍니다
Comment on lines
35
to
55
| return DateUtils.getDayDifference(LocalDateTime.now(), firstMemberAttendance.get().getCreatedAt()) != 0; | ||
| boolean isNotAttended = | ||
| DateUtils.getDayDifference(LocalDateTime.now(), memberLatestAttendance.get().getCreatedAt()) != ZERO; | ||
|
|
||
| return isNotAttended; |
There was a problem hiding this comment.
여기 바로 return 하는거 의견 제시해봅니당..
There was a problem hiding this comment.
여기 바로 return 하는거 의견 제시해봅니당..
넵! 뭔가 필요없이 코드라인이 낭비되는 느낌이 드네요..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers