Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ feat ] scrap field 수정 + livedata -> flow #55

Merged
merged 4 commits into from
Dec 23, 2023
Merged

[ feat ] scrap field 수정 + livedata -> flow #55

merged 4 commits into from
Dec 23, 2023

Conversation

kimwest00
Copy link
Contributor

@kimwest00 kimwest00 commented Dec 23, 2023 •
edited
Loading

‼️ 관련 이슈

관련 이슈를 링크해주세요

✨ PR Point

해당 PR에 대해 간략하게 작성해주세요

  • scrap field 수정 ( gptModel, timeOfDay)
  • livedata -> stateflow migration
  • repository 단에서 view에서 쓰는 model로 변환 (toScrap)

To Reviewers

참고사항및 특이점이 있으면 적어주세요

  • 홈에서 set, unscrap api의 경우 아직 home api 변경사항 적용전이여서 테스트 해보지 못했습니다. swagger상에서 추가해보고 list에 반영되는지 확인하였습니다
  • authapi의 경우 v2로 반환이 안되어서 일시적으로 수정해두었는데 필요시 v2 제거하여 커밋올리겠습니다

kimwest00 added 3 commits December 10, 2023 17:22
fix:#53 scrap model 수정
7050c2a 
field 추가
gptmodel, date 서버 enum data -> ui 로 분기처리
fix:#53 data, repository return 값 수정
56c4041
fix:#53 viewmodel, screen 수정
e6d23a6
@kimwest00 kimwest00 self-assigned this Dec 23, 2023
@kimwest00 kimwest00 linked an issue Dec 23, 2023 that may be closed by this pull request
[ Feat ] ScrapViewmodel StateFlow 마이그레이션 + field 수정 #53
Closed
2 tasks
@kimwest00 kimwest00 added the 🖥️feat 기능 개발 label Dec 23, 2023
@kimwest00 kimwest00 added this to the VER 2.0 업데이트 milestone Dec 23, 2023
gomsang
gomsang approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@gomsang gomsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다 ~ URL 부분은 당장 수정안해도 대응되는 부분이라 나중에 수정해도 될 것 같아요.

app/src/main/java/com/dev/briefing/data/api/AuthApi.kt Outdated
@@ -12,17 +12,17 @@ import retrofit2.http.Path
import retrofit2.http.Query

interface AuthApi {
@POST("/members/auth/google")
@POST("/v2/members/auth/google")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrofit base URL 에 /v2/를 미리 기입해두고 사용할 것인지 아니면 각각 엔드포인트 마다 /v2/ 처럼 붙여줄 것인지

@kimwest00 kimwest00 merged commit b28ce92 into develop Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomsang gomsang gomsang approved these changes

Assignees

@kimwest00 kimwest00

Labels
🖥️feat 기능 개발
Projects
None yet
Milestone
VER 2.0 업데이트
Development

Successfully merging this pull request may close these issues.

[ Feat ] ScrapViewmodel StateFlow 마이그레이션 + field 수정
2 participants
@kimwest00 @gomsang