Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add @here & Server Name #344

Conversation

IgnisAlienus
Copy link
Contributor

Adds the ability to turn on @here for Admin Requests in Discord. This allows for pinging of all ONLINE Squad Admins if the Admin Request is going to a Squad Admin only Channel.

Added the ServerName option so you can tell what server the request is coming from for communities with multi servers without having to create multi channels for each server's admin request notifs.

IgnisAlienus and others added 3 commits January 24, 2024 20:13
Update to instead of using an option for ServerName, use the this.server.serverName
@IgnisAlienus
Copy link
Contributor Author

Updated to use a this.server.serverName instead of using a plugin option of this.options.serverName.

@fantinodavide
Copy link
Contributor

The readme file hasn't been updated when removing the server name option, also, updating it shouldn't be a manual process as there is a command and a pre-commit hook to automatically update the config file, readme, and lint/format the files affected by the changes.

@IgnisAlienus
Copy link
Contributor Author

The readme file hasn't been updated when removing the server name option, also, updating it shouldn't be a manual process as there is a command and a pre-commit hook to automatically update the config file, readme, and lint/format the files affected by the changes.

Updated ReadME.

Yeah, things are wonky in my fork/branch so it was easier for me to just modify the files directly in this PR.

Copy link
Collaborator

@werewolfboy13 werewolfboy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not manually edit the readme, please use yarn lint.

Please push a commit with that edit done if it hasn't already been ran.

@werewolfboy13
Copy link
Collaborator

@IgnisAlienus I see you removed the server name, was that intended?

@IgnisAlienus
Copy link
Contributor Author

IgnisAlienus commented Jan 25, 2024

@IgnisAlienus I see you removed the server name, was that intended?

Yes. this.server.serverName returns the Server Name that I is fetched somewhere else in SquadJS

@werewolfboy13 werewolfboy13 added core bug Bug related to the core SquadJS API patch Patch Change labels Feb 5, 2024
@werewolfboy13 werewolfboy13 merged commit 9de44f6 into Team-Silver-Sphere:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core bug Bug related to the core SquadJS API patch Patch Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants