-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add @here & Server Name #344
Feat: Add @here & Server Name #344
Conversation
Update to instead of using an option for ServerName, use the this.server.serverName
Updated to use a this.server.serverName instead of using a plugin option of this.options.serverName. |
The readme file hasn't been updated when removing the server name option, also, updating it shouldn't be a manual process as there is a command and a pre-commit hook to automatically update the config file, readme, and lint/format the files affected by the changes. |
Updated ReadME. Yeah, things are wonky in my fork/branch so it was easier for me to just modify the files directly in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not manually edit the readme, please use yarn lint
.
Please push a commit with that edit done if it hasn't already been ran.
@IgnisAlienus I see you removed the server name, was that intended? |
Yes. this.server.serverName returns the Server Name that I is fetched somewhere else in SquadJS |
Adds the ability to turn on @here for Admin Requests in Discord. This allows for pinging of all ONLINE Squad Admins if the Admin Request is going to a Squad Admin only Channel.
Added the ServerName option so you can tell what server the request is coming from for communities with multi servers without having to create multi channels for each server's admin request notifs.