Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate "victim" friend from DiscordKillFeed plugin #364

Merged

Conversation

Ulibos
Copy link
Contributor

@Ulibos Ulibos commented Jul 11, 2024

Fixes an oopsie I did in EOS migration, duplicating the field in the plugin. I've removed the on that wasn't performing safety checks and was ocasionally crashing people's squadjs.

@lbzepoqo
Copy link
Contributor

You're not going to update it to Victim's EOS ID instead just like with the other plugins in #354 ?

@Ulibos
Copy link
Contributor Author

Ulibos commented Jul 11, 2024

I'm an idiot... I forgot my own code. That is the reason there was that duplicate. It was meant to be rewritten to show EOS which I forgot to do. I'll fix it in a minute.

@Ulibos Ulibos force-pushed the fix/killfeed-victim-duplicate branch from fc045b3 to f51c656 Compare July 11, 2024 18:11
@Ulibos
Copy link
Contributor Author

Ulibos commented Jul 11, 2024

Fixed.

@werewolfboy13 werewolfboy13 added plugin bug Bug related to the SquadJS plugins patch Patch Change labels Jul 11, 2024
@werewolfboy13 werewolfboy13 merged commit 9cc0d58 into Team-Silver-Sphere:master Jul 11, 2024
@Ulibos Ulibos deleted the fix/killfeed-victim-duplicate branch July 11, 2024 22:26
@Thomas-Smyth Thomas-Smyth changed the title fix: remove duplicate 'Victim' field from killfeed. Remove duplicate "victim" friend from DiscordKillFeed plugin Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch Change plugin bug Bug related to the SquadJS plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants