Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Record Git SHA in Logger #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Record Git SHA in Logger #139

wants to merge 1 commit into from

Conversation

rcahoon
Copy link
Member

@rcahoon rcahoon commented Sep 21, 2024

Description

This allows us to introspect which version of the software is currently deployed to a robot

How Has This Been Tested?

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@rcahoon rcahoon requested a review from dejabot September 21, 2024 17:28
Copy link
Contributor

@dejabot dejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Minor thoughts/suggestions for some other fields to log.

@@ -114,6 +115,8 @@ public void robotInit() {
// TODO: add support for simulation logging/replay
}

Logger.recordMetadata("GitSHA", BuildConstants.GIT_SHA);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth logging BuildConstants.{BUILD_DATE, GIT_BRANCH, DIRTY} as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants