This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Rule action persistence policies #146
Open
rcahoon
wants to merge
1
commit into
rcahoon/mf3-superstructure
Choose a base branch
from
rcahoon/mf3-rule-persistence
base: rcahoon/mf3-superstructure
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
reviewed
Dec 13, 2024
e7abdd1
to
dad9af2
Compare
Thanks! I was wondering since this is only adding in the one class. Maybe that's the only one worth static imports at this time, tho..
…-------- Original Message --------
On 12/12/24 8:43 PM, Ryan Cahoon wrote:
@rcahoon commented on this pull request.
---------------------------------------------------------------
In [.vscode/settings.json](#146 (comment)):
> @@ -33,5 +33,17 @@
"diffEditor.ignoreTrimWhitespace": false,
"java.format.settings.url": "https://raw.githubusercontent.com/google/styleguide/gh-pages/eclipse-java-google-style.xml",
"java.checkstyle.configuration": "${workspaceFolder}/.github/linters/checkstyle.xml",
- "java.checkstyle.version": "9.3"
+ "java.checkstyle.version": "9.3",
+ "java.completion.favoriteStaticMembers": [
+ "com.team766.framework3.RulePersistence.*",
Yep, this makes autocomplete include static members of this class, even if there isn't an import static for them yet (autocomplete will add the import static automatically)
—
Reply to this email directly, [view it on GitHub](#146 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AY4ADJVIWCB3SUE4QCZNAYT2FJQYLAVCNFSM6AAAAABTQ5NXHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBRGI4DONZQG4).
You are receiving this because your review was requested.Message ID: ***@***.***>
|
dad9af2
to
5f32fb1
Compare
6f6c750
to
1558762
Compare
We can certainly add more :) I was just keeping the changes contained to those relevant to the rest of this PR |
5f32fb1
to
b12b003
Compare
1558762
to
af3ac74
Compare
dejabot
approved these changes
Dec 14, 2024
b12b003
to
76d8c55
Compare
af3ac74
to
4963833
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the user to specify how the RuleEngine should handle a Rule's action when the action completes or the Rule stops triggering.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.