This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Hierarchical rules #147
Open
Hierarchical rules #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
reviewed
Dec 13, 2024
rcahoon
force-pushed
the
rcahoon/mf3-rule-persistence
branch
from
6f6c750 to
1558762
Compare
rcahoon
force-pushed
the
rcahoon/mf3-rule-hierarchy
branch
from
1c71492 to
3c34b9f
Compare
rcahoon
force-pushed
the
rcahoon/mf3-rule-persistence
branch
from
1558762 to
af3ac74
Compare
rcahoon
force-pushed
the
rcahoon/mf3-rule-hierarchy
branch
from
3c34b9f to
8fd414b
Compare
dejabot
approved these changes
Dec 14, 2024
rcahoon
force-pushed
the
rcahoon/mf3-rule-persistence
branch
from
af3ac74 to
4963833
Compare
rcahoon
force-pushed
the
rcahoon/mf3-rule-hierarchy
branch
from
8fd414b to
850a86a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow defining Rules in a hierarchy so that the Rules' conditions compose. This is useful for specifying controls for different "modes" of the robot.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.