require authentication as 'ref' user to view ref pages #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
commented
Nov 22, 2024
dejabot
commented
- add ref password to settings
- require either ref or admin authentication in order to access ref pages
rcahoon
reviewed
Nov 30, 2024
| @@ -11,6 +11,10 @@ import ( | |||
| // through a websockets integration, the head ref will be able to see score updates submitted by other | |||
| // refs in realtime. | |||
| func (web *Web) headrefDisplayHandler(w http.ResponseWriter, r *http.Request) { | |||
| if !web.userIsExpected(w, r, []string{adminUser, refUser}) { | |||
There was a problem hiding this comment.
should there be some sort of error message returned to the client here? something equivalent to handleWebErr
| @@ -41,6 +45,10 @@ func (web *Web) headrefDisplayHandler(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| // The websocket endpoint for the ref display client to receive status updates. | |||
| func (web *Web) headrefDisplayWebsocketHandler(w http.ResponseWriter, r *http.Request) { | |||
| if !web.userIsExpected(w, r, []string{adminUser, refUser}) { | |||
There was a problem hiding this comment.
should there be some sort of error message returned to the client here? something equivalent to handleWebErr
| @@ -58,14 +59,24 @@ func (web *Web) renderLogin(w http.ResponseWriter, r *http.Request, errorMessage | |||
| } | |||
| } | |||
|
|
|||
| func contains(slice []string, expected string) bool { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.