Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFTP connection invalid port causes NPE #1003

Closed
avuton opened this issue Feb 7, 2018 · 0 comments
Closed

SFTP connection invalid port causes NPE #1003

avuton opened this issue Feb 7, 2018 · 0 comments
Assignees
Labels
Issue-Bug Related unexpected behavior or something worth investigating.

Comments

@avuton
Copy link
Contributor

avuton commented Feb 7, 2018

Host/user/pass don't matter, entering an invalid TCP port (above 65535) causes an NPE like the one below. This is from commit cdba479.

02-07 10:22:45.119  4176  4176 E AndroidRuntime: FATAL EXCEPTION: main
02-07 10:22:45.119  4176  4176 E AndroidRuntime: Process: com.amaze.filemanager, PID: 4176
02-07 10:22:45.119  4176  4176 E AndroidRuntime: java.lang.NullPointerException: Attempt to read from field 'java.lang.Throwable com.amaze.filemanager.filesystem.ssh.tasks.AsyncTaskResult.exception' on a null object reference
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at com.amaze.filemanager.filesystem.ssh.tasks.GetSshHostFingerprintTask.onPostExecute(GetSshHostFingerprintTask.java:119)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at com.amaze.filemanager.filesystem.ssh.tasks.GetSshHostFingerprintTask.onPostExecute(GetSshHostFingerprintTask.java:64)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.os.AsyncTask.finish(AsyncTask.java:695)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.os.AsyncTask.-wrap1(Unknown Source:0)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:712)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6494)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440)
02-07 10:22:45.119  4176  4176 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
02-07 10:22:45.124  1320 19465 W ActivityManager:   Force finishing activity com.amaze.filemanager/.activities.MainActivity
@EmmanuelMess EmmanuelMess added the Issue-Bug Related unexpected behavior or something worth investigating. label Feb 7, 2018
@TranceLove TranceLove self-assigned this Feb 9, 2018
TranceLove added a commit to TranceLove/AmazeFileManager that referenced this issue Feb 9, 2018
Fixes TeamAmaze#1003. Also changed member naming back to Java's coding convention (TeamAmaze#986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Related unexpected behavior or something worth investigating.
Projects
None yet
Development

No branches or pull requests

3 participants