Feature: Box Expansion #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BoxInfinityScrollItem.h - BoxTray.h - BoxWindow.h
- Missing pragma argument
- Not required in the actual Box Expansion code but handy header to have
- 99% functional when utilising Vanilla migration - Currently cannot load game without migration, however FromBytes() does successfully finish
- injectPlayerWork() is trampolined onto FieldCanvas$$Start which injects Box Expansion into the PlayerWork post-startup. -
- Base 40 boxes successfully expanded to 80 boxes. - Migration work implemented. Vanilla saves will have their base 40 boxes copied and stored into the new 80 box array. - To prevent issues with pre-load initialization, Playerwork is injected through trampolining off of FieldCanvas$$Start. This is not the case if migration is performed which it can be successfully overwritten during initialization without issue. - BoxList view updated and re-scaled to display all 80 boxes which can be functionally navigated to. - Requires updated Box UI assetbundle from RomFS repo
SaltContainer
requested changes
Jun 10, 2024
src/mod/externals/SmartPoint/Components/PlayerPrefsProvider_PlayerWork_.h
Outdated
Show resolved
Hide resolved
- Unified PlayerPrefsProvider_PlayerWork_.h & PlayerPrefsProvider_ViewerSettings_.h to instead use a template such as other classes such as List
SaltContainer
requested changes
Jun 10, 2024
- Fixed PlayerPrefsProvider.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Box Expansion 📦
FieldCanvas$$Start. This is not the case if migration is performed which it can be successfully overwritten during initialization without issue.