Static Held Items Port (Starlight -> ExLaunch) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- Removed redundant code already covered by wild_held_items.cpp - Added egg check to wild_held_items.cpp
SaltContainer
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows static encounters to have held items + modifies item rates based on if the player's first pokemon has the ability super luck or compound eyes.
Changed the 'magic number' declaration of the aforementioned abilities in the SL patch to instead be calculated through array_indexing from items.h. e.g
array_index(ABILITIES, "Super Luck")if (!firstPoke->IsEgg(2, nullptr))updated to use the EggCheckType enum:PokePara::EggCheckType::BOTH_EGGfromEggCheckType.hMisc Change: I added the functions
GetMonsNo()andGetFormNo()toAccessor.h. They don't contribute to this issue but may as well merge them in for future usage.Rotom Battle:
